linux-kernel - scsi_debug: shared dev context, BUG or FEATURE?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tw6e4o75.fsf@dmlp.sw.ru>
Date:   Mon, 27 Mar 2017 20:35:58 +0300
From:   Dmitry Monakhov <dmonakhov@...nvz.org>
To:     LKML <linux-kernel@...r.kernel.org>
CC:     dgilbert@...erlog.com, martin.petersen@...cle.com
Subject: scsi_debug: shared dev context, BUG or FEATURE?

Hi scsi_debug has very strange structure
from one point it supports dynamic number of devices
but from other point context is common for all devices:
 - dif_storep (array of t10 dif tuples)
 - map_storep (block map for thinprovision)
 - fake_storep (in memory data storage)
 - sdebug_q_arr (queue array)
So basically we may have many devices with single context which refers
common data. Are any sane reason to share context between devices?
Who use such behaviour?

IMHO this is a pure bug. Please correct me if I'm wrong, I'll plan to
fix that by allocation separate context for each dev.