linux-kernel - Re: [PATCH V7 00/18] blk-throttle: add .low limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <567d5361-7d6b-c53e-8ada-a2966e48dc54@fb.com>
Date:   Mon, 27 Mar 2017 13:11:26 -0600
From:   Jens Axboe <axboe@...com>
To:     Shaohua Li <shli@...com>, Jens Axboe <axboe@...nel.dk>
CC:     <linux-kernel@...r.kernel.org>, <linux-block@...r.kernel.org>,
        <tj@...nel.org>, Vivek Goyal <vgoyal@...hat.com>,
        <jmoyer@...hat.com>, <Kernel-team@...com>
Subject: Re: [PATCH V7 00/18] blk-throttle: add .low limit

On 03/27/2017 01:00 PM, Shaohua Li wrote:
> On Mon, Mar 27, 2017 at 12:15:29PM -0600, Jens Axboe wrote:
>> On 03/27/2017 11:51 AM, Shaohua Li wrote:
>>> V6->V7:
>>> - Don't overload blk stat, which will simplify the code. This will add extra
>>>   space in bio/request though with the low interface configure option on.
>>
>> Hmm, why? As far as I can see, it just makes things worse.
> 
> Part of the reason is the new callback based blk stat makes enabling stat less
> straightforward. I probably can create a fake callback and enalbing the stat
> though. Only the last 3 patches depend on this, if you prefer, I can resend
> them and add the overload back.

Yeah, I think that would be a big improvement.

-- 
Jens Axboe