linux-kernel - Re: [PATCH v3] regulator: core: Limit propagation of parent voltage count and list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bf7e7d72-608b-9645-302f-34401a8121ee@osg.samsung.com>
Date:   Mon, 27 Mar 2017 18:41:52 -0400
From:   Javier Martinez Canillas <javier@....samsung.com>
To:     Matthias Kaehlcke <mka@...omium.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>,
        Brian Norris <briannorris@...omium.org>
Subject: Re: [PATCH v3] regulator: core: Limit propagation of parent voltage
 count and list

Hello Matthias,

On 03/27/2017 05:31 PM, Matthias Kaehlcke wrote:
> Commit 26988efe11b1 ("regulator: core: Allow to get voltage count and
> list from parent") introduces the propagation of the parent voltage
> count and list for regulators that don't provide this information
> themselves. The goal is to support simple switch regulators, however as
> a side effect normal continuous regulators can leak details of their
> supplies and provide consumers with inconsistent information.
> 
> Limit the propagation of the voltage count and list to switch
> regulators.
> 

Should we add a Fixes: 26988efe11b1 ("regulator: core: Allow to get voltage
count and list from parent") tag?

> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> ---
> Changes in v3:
>  - Removed unused variable ops from regulator_count_voltages()
>  - Updated commit message to use correct format for referencing commits
>  (sorry, both stem from using different trees for testing and upstreaming)
>

You should add complete patch history, not only the delta with latest version.

[snip]

>  
> +	if (!rdev->desc->ops->get_voltage &&
> +	    !rdev->desc->ops->get_voltage_sel &&
> +	    !rdev->desc->ops->list_voltage &&
> +	    !rdev->desc->fixed_uV)
> +		rdev->is_switch = true;
> +

Again, I think the check for get_voltage_sel is superfluous since !list_voltage
implies the former, otherwise regulator_register() would had returned -EINVAL.

Patch looks good to me though and I also see no regressions with it so:

Reviewed-by: Javier Martinez Canillas <javier@....samsung.com>
Tested-by: Javier Martinez Canillas <javier@....samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America