linux-kernel - Re: [PATCH] netvsc: fix dereference before null check errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170327.160119.277346270230368504.davem@davemloft.net>
Date:   Mon, 27 Mar 2017 16:01:19 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     haiyangz@...rosoft.com
Cc:     colin.king@...onical.com, kys@...rosoft.com,
        sthemmin@...rosoft.com, devel@...uxdriverproject.org,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netvsc: fix dereference before null check errors

From: Haiyang Zhang <haiyangz@...rosoft.com>
Date: Mon, 27 Mar 2017 00:50:27 +0000

> 
> 
>> -----Original Message-----
>> From: Colin King [mailto:colin.king@...onical.com]
>> Sent: Saturday, March 25, 2017 10:27 AM
>> To: KY Srinivasan <kys@...rosoft.com>; Haiyang Zhang
>> <haiyangz@...rosoft.com>; Stephen Hemminger <sthemmin@...rosoft.com>;
>> devel@...uxdriverproject.org; netdev@...r.kernel.org
>> Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org
>> Subject: [PATCH] netvsc: fix dereference before null check errors
>> 
>> From: Colin Ian King <colin.king@...onical.com>
>> 
>> ndev is being checked to see if it is a null pointer however before
>> the null check ndev is being dereferenced; hence there is a potential
>> null pointer dereference bug that needs fixing. Fix this by only
>> dereferencing ndev after the null check.
>> 
>> Detected by CoverityScan, CID#1420760, CID#140761 ("Dereference
>> before null check")
>> 
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> 
> Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>

Applied.