linux-kernel - Re: [PATCH] ACPI : Update platform device numa node based on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1932728.uFK6bUjlgv@aspire.rjw.lan>
Date:   Tue, 28 Mar 2017 23:43:12 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Shanker Donthineni <shankerd@...eaurora.org>
Cc:     Len Brown <lenb@...nel.org>,
        linux-acpi <linux-acpi@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Vikram Sethi <vikrams@...eaurora.org>
Subject: Re: [PATCH] ACPI : Update platform device numa node based on _PXM method

On Tuesday, March 21, 2017 09:54:30 AM Shanker Donthineni wrote:
> The optional _PXM method evaluates to an integer that identifies the
> proximity domain of a device object. This patch implements support for
> ACPI _PXM method and updates the platform device numa node id using
> acpi_get_node(), which provides the PXM to NUMA mapping information.
> 
> Signed-off-by: Shanker Donthineni <shankerd@...eaurora.org>

What exactly is the motivation here?

> ---
>  drivers/acpi/acpi_platform.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
> index b4c1a6a..83d953e 100644
> --- a/drivers/acpi/acpi_platform.c
> +++ b/drivers/acpi/acpi_platform.c
> @@ -119,11 +119,14 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev,
>  	if (IS_ERR(pdev))
>  		dev_err(&adev->dev, "platform device creation failed: %ld\n",
>  			PTR_ERR(pdev));
> -	else
> +	else {
> +		set_dev_node(&pdev->dev, acpi_get_node(adev->handle));
>  		dev_dbg(&adev->dev, "created platform device %s\n",
>  			dev_name(&pdev->dev));
> +	}
>  
>  	kfree(resources);
> +
>  	return pdev;
>  }
>  EXPORT_SYMBOL_GPL(acpi_create_platform_device);
>