linux-kernel - Re: [PATCH] kasan: avoid -Wmaybe-uninitialized warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170328162942.eb08b50af725428a4be25f2b@linux-foundation.org>
Date:   Tue, 28 Mar 2017 16:29:42 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Alexander Potapenko <glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Andrey Konovalov <andreyknvl@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        kasan-dev@...glegroups.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kasan: avoid -Wmaybe-uninitialized warning

On Thu, 23 Mar 2017 16:04:09 +0100 Arnd Bergmann <arnd@...db.de> wrote:

> gcc-7 produces this warning:
> 
> mm/kasan/report.c: In function 'kasan_report':
> mm/kasan/report.c:351:3: error: 'info.first_bad_addr' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>    print_shadow_for_address(info->first_bad_addr);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> mm/kasan/report.c:360:27: note: 'info.first_bad_addr' was declared here
> 
> The code seems fine as we only print info.first_bad_addr when there is a shadow,
> and we always initialize it in that case, but this is relatively hard
> for gcc to figure out after the latest rework. Adding an intialization
> in the other code path gets rid of the warning.
> 
> ...
>
> --- a/mm/kasan/report.c
> +++ b/mm/kasan/report.c
> @@ -109,6 +109,8 @@ const char *get_wild_bug_type(struct kasan_access_info *info)
>  {
>  	const char *bug_type = "unknown-crash";
>  
> +	info->first_bad_addr = (void *)(-1ul);
> +
>  	if ((unsigned long)info->access_addr < PAGE_SIZE)
>  		bug_type = "null-ptr-deref";
>  	else if ((unsigned long)info->access_addr < TASK_SIZE)

A weird, ugly and seemingly-unneeded statement should have a comment
explaining its existence, no?

Fortunately it is no longer needed.  We now have:

static void print_error_description(struct kasan_access_info *info)
{
	const char *bug_type = "unknown-crash";
	u8 *shadow_addr;

	info->first_bad_addr = find_first_bad_addr(info->access_addr,
						info->access_size);

	shadow_addr = (u8 *)kasan_mem_to_shadow(info->first_bad_addr);

	...