linux-kernel - Re: [PATCH] selftests/vm: Set mmap()'s fd as -1 for MAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170328164227.95f3cc342da28b92be45e25e@linux-foundation.org>
Date:   Tue, 28 Mar 2017 16:42:27 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     shuah@...nel.org
Cc:     SeongJae Park <sj38.park@...il.com>,
        Simon Guo <wei.guo.simon@...il.com>,
        linux-kselftest@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH] selftests/vm: Set mmap()'s fd as -1 for MAP_ANONYMOUS
 flag

On Fri, 24 Mar 2017 10:47:55 -0600 Shuah Khan <shuah@...nel.org> wrote:

> > On Wed, Mar 15, 2017 at 10:19 PM, SeongJae Park <sj38.park@...il.com> wrote:
> >> Man page of mmap() says that portable applications should ensure fd
> >> argument to be -1 if MAP_ANONYMOUS flag is set as below:
> >> ```
> >> The  mapping is not backed by any file; its contents are initialized to
> >> zero.  The fd and offset arguments are ignored; however, some
> >> implementations require  fd  to be  -1  if  MAP_ANONYMOUS  (or
> >> MAP_ANON)  is specified, and portable applications
> >> should ensure this.
> >> ```
> >>
> >> However, few mmap() calls under selftests/vm/ uses 0 as fd though they
> >> use MAP_ANONYMOUS flag.  This commit changes the argument to be -1 as
> >> recommended.
> 
> Hi Andrew,
> 
> Do you have comments on this patch? Please Ack it if you would
> like me to take it thorugh ksefltest tree.

Acked-by: Andrew Morton <akpm@...ux-foundation.org>