[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170328061259.GC20135@gmail.com>
Date: Tue, 28 Mar 2017 08:12:59 +0200
From: Ingo Molnar <mingo@...nel.org>
To: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
Andrew Morton <akpm@...ux-foundation.org>, x86@...nel.org,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
"H. Peter Anvin" <hpa@...or.com>, Andi Kleen <ak@...ux.intel.com>,
Dave Hansen <dave.hansen@...el.com>,
Andy Lutomirski <luto@...capital.net>,
linux-arch@...r.kernel.org, linux-mm@...ck.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/8] x86/dump_pagetables: Add support 5-level paging
* Kirill A. Shutemov <kirill.shutemov@...ux.intel.com> wrote:
> +#if PTRS_PER_P4D > 1
> +
> +static void walk_p4d_level(struct seq_file *m, struct pg_state *st, pgd_t addr,
> + unsigned long P)
Pretty ugly line break. Either don't break the line, or break it in a more logical
place, like:
static void
walk_p4d_level(struct seq_file *m, struct pg_state *st, pgd_t addr, unsigned long P)
> + start = (p4d_t *) pgd_page_vaddr(addr);
The space between the type cast and the function invocation is not needed.
Thanks,
Ingo
Powered by blists - more mailing lists