linux-kernel - Re: [PATCH] serial: 8250_EXAR: fix duplicate Kconfig text and add missing help text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170328075248.GA3992@sudip-tp>
Date:   Tue, 28 Mar 2017 08:52:48 +0100
From:   Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     linux-kernel@...r.kernel.org,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org
Subject: Re: [PATCH] serial: 8250_EXAR: fix duplicate Kconfig text and add
 missing help text

On Mon, Mar 27, 2017 at 07:39:10PM -0400, Paul Gortmaker wrote:
> In commit d0aeaa83f0b0f7a92615bbdd6b1f96812f7dcfd2 ("serial: exar:
> split out the exar code from 8250_pci") the exar driver got its own
> Kconfig.  However the text for the new option was never changed from
> the original 8250_PCI text, and hence it appears confusing when you
> get asked the same question twice:
> 
>   8250/16550 PCI device support (SERIAL_8250_PCI) [Y/n/m/?] (NEW)
>     8250/16550 PCI device support (SERIAL_8250_EXAR) [Y/n/m] (NEW)
> 
> Adding to the confusion, is that there is no help text for this new
> option to indicate it is specific to a certain family of cards.
> 
> Fix both issues at the same time, as well as the space vs. tab issues
> introduced in the same commit.
> 
> Fixes: d0aeaa83f0b0 ("serial: exar: split out the exar code from 8250_pci")
> Cc: Andy Shevchenko <andy.shevchenko@...il.com>
> Cc: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>

Acked-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>