linux-kernel - Re: [PATCHv3 1/2] mfd: cpcap: Add missing include dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170328081633.dgt6b6nnomkluxre@dell>
Date:   Tue, 28 Mar 2017 09:16:33 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Jacek Anaszewski <jacek.anaszewski@...il.com>
Cc:     Sebastian Reichel <sre@...nel.org>,
        Richard Purdie <rpurdie@...ys.net>,
        Pavel Machek <pavel@....cz>, Tony Lindgren <tony@...mide.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3 1/2] mfd: cpcap: Add missing include dependencies

On Mon, 27 Mar 2017, Jacek Anaszewski wrote:
> On 03/27/2017 04:26 PM, Lee Jones wrote:
> > On Fri, 24 Mar 2017, Jacek Anaszewski wrote:
> >> On 03/24/2017 09:47 AM, Sebastian Reichel wrote:
> >>> This fixes compilation for files, that try to include the
> >>> cpcap header in alphabetically sorted #include lists.
> >>>
> >>> Acked-by: Pavel Machek <pavel@....cz>
> >>> Acked-by: Tony Lindgren <tony@...mide.com>
> >>> Signed-off-by: Sebastian Reichel <sre@...nel.org>
> >>> ---
> >>> Changes since PATCHv2:
> >>>  - Add Acked-by from Tony & Pavel
> >>> ---
> >>>  include/linux/mfd/motorola-cpcap.h | 3 +++
> >>>  1 file changed, 3 insertions(+)
> >>>
> >>> diff --git a/include/linux/mfd/motorola-cpcap.h b/include/linux/mfd/motorola-cpcap.h
> >>> index 793aa695faa0..aefc49cb7ba9 100644
> >>> --- a/include/linux/mfd/motorola-cpcap.h
> >>> +++ b/include/linux/mfd/motorola-cpcap.h
> >>> @@ -14,6 +14,9 @@
> >>>   * published by the Free Software Foundation.
> >>>   */
> >>>  
> >>> +#include <linux/device.h>
> >>> +#include <linux/regmap.h>
> >>> +
> >>>  #define CPCAP_VENDOR_ST		0
> >>>  #define CPCAP_VENDOR_TI		1
> >>
> >> Both patches applied to the for-next branch of linux-leds.git, thanks.
> > 
> > Que?
> 
> Ah, sorry, for some reason I silently assumed that Tony gave ack on
> your behalf :-) Probably due to lack of your activity in the subject
> and Tony's understanding thereof [0].

Right, but you still need to align with other Maintainers despite
expert reviews, since they are in a better position to help avoid
potential merge conflicts.

> Can I have your ack for this patch going through LED tree then?

I've gone one better and provided you with a pull-request.  It's the
best way to avoid merge conflict, subsequently upsetting the Big
Penguin.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog