linux-kernel - Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

Open Source and information security mailing list archives

Message-ID: <20170328092103.GQ6986@localhost.localdomain>
Date:   Tue, 28 Mar 2017 10:21:03 +0100
From:   Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:     Daniel Baluta <daniel.baluta@....com>
CC:     <nicoleotsuka@...il.com>, <broonie@...nel.org>,
        <alsa-devel@...a-project.org>, <timur@...i.org>,
        <Xiubo.Lee@...il.com>, <linux-kernel@...r.kernel.org>,
        <lgirdwood@...il.com>, <tiwai@...e.com>, <fabio.estevam@....com>,
        <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk
 cleanup

On Tue, Mar 28, 2017 at 11:58:52AM +0300, Daniel Baluta wrote:
> Resource managed devm_clk_get only works with platform's device dev.
> 

I feel like this could use an explaination of why not using devm
is the correct fix, rather than just using the platform device
for the call. Its not obvious to me, that using the platform
device would be an issue.

Thanks,
Charles

> Reported-by: Nicolin Chen <nicoleotsuka@...il.com>
> Signed-off-by: Daniel Baluta <daniel.baluta@....com>
> ---
>  sound/soc/fsl/imx-wm8962.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/fsl/imx-wm8962.c b/sound/soc/fsl/imx-wm8962.c
> index 3d894d9..52659fa 100644
> --- a/sound/soc/fsl/imx-wm8962.c
> +++ b/sound/soc/fsl/imx-wm8962.c
> @@ -231,7 +231,7 @@ static int imx_wm8962_probe(struct platform_device *pdev)
>  		goto fail;
>  	}
>  
> -	codec_clk = devm_clk_get(&codec_dev->dev, NULL);
> +	codec_clk = clk_get(&codec_dev->dev, NULL);
>  	if (IS_ERR(codec_clk)) {
>  		ret = PTR_ERR(codec_clk);
>  		dev_err(&codec_dev->dev, "failed to get codec clk: %d\n", ret);
> @@ -239,6 +239,7 @@ static int imx_wm8962_probe(struct platform_device *pdev)
>  	}
>  
>  	data->clk_frequency = clk_get_rate(codec_clk);
> +	clk_put(codec_clk);
>  
>  	data->dai.name = "HiFi";
>  	data->dai.stream_name = "HiFi";
> -- 
> 2.7.4
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives