linux-kernel - Re: [PATCH] fault-inject: use correct check for interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACT4Y+Z1dGhUBqb2BuSQdkCOWVFqWw_5zDtXUe3yYdrQ_42giA@mail.gmail.com>
Date:   Tue, 28 Mar 2017 11:58:36 +0200
From:   Dmitry Vyukov <dvyukov@...gle.com>
To:     Akinobu Mita <akinobu.mita@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [PATCH] fault-inject: use correct check for interrupts

On Sat, Mar 25, 2017 at 8:18 AM, Akinobu Mita <akinobu.mita@...il.com> wrote:
> 2017-03-21 18:18 GMT+09:00 Dmitry Vyukov <dvyukov@...gle.com>:
>> in_interrupt() also returns true when bh is disabled in task context.
>> That's not what fail_task() wants to check.
>> Use the new in_task() predicate that does the right thing.
>>
>> Signed-off-by: Dmitry Vyukov <dvyukov@...gle.com>
>> Cc: akinobu.mita@...il.com
>> Cc: linux-kernel@...r.kernel.org
>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>> Cc: linux-mm@...ck.org
>
> This change looks good to me.
>
> Reviewed-by: Akinobu Mita <akinobu.mita@...il.com>


Andrew, will you take this to mm please?