linux-kernel - Re: [PATCH] usb: gadget: udc: remove redundant initial assignments to the pointer 's'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <66ad4118-7c0a-06b9-b780-d0d613cb8152@cogentembedded.com>
Date:   Tue, 28 Mar 2017 13:20:14 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Colin King <colin.king@...onical.com>,
        Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        yuan linyu <Linyu.Yuan@...atel-sbell.com.cn>,
        Bhumika Goyal <bhumirks@...il.com>,
        Michal Nazarewicz <mina86@...a86.com>,
        linux-usb@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: udc: remove redundant initial assignments to
 the pointer 's'

Hello!

On 3/28/2017 1:34 AM, Colin King wrote:

> From: Colin Ian King <colin.king@...onical.com>
>
> The initial setting of pointer s to the driver name or to the literal
> string "(none)" is redundant as later it is always set to point to
> a different literal string before it is printed log.  Remove this

    Printed to log, perhaps?

> redundant code.
>
> Detected with CoverityScan, CID#1227032, CID#1227033 ("Unused Value")
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
[...]

MBR, Sergei