linux-kernel - Re: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1490699810.3546.10.camel@nxp.com>
Date:   Tue, 28 Mar 2017 14:16:50 +0300
From:   Leonard Crestez <leonard.crestez@....com>
To:     Dong Aisheng <dongas86@...il.com>
CC:     Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        <linux-arm-kernel@...ts.infradead.org>,
        Fabio Estevam <fabio.estevam@....com>,
        Fugang Duan <fugang.duan@....com>,
        "Octavian Purdila" <octavian.purdila@....com>,
        Florian Fainelli <f.fainelli@...il.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY

On Fri, 2017-03-24 at 14:43 +0800, Dong Aisheng wrote:
> Hi Leonard,
> 
> On Wed, Mar 22, 2017 at 04:27:37PM +0200, Leonard Crestez wrote:
> > 
> > The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY.
> > Add this driver to the default imx config since the device is present on
> > one of the evaluation boards.
> Upstream currently no evaluation board support.
> 
> This may leave to Shawn to decide whether apply it.

Really? But the dts for this eval board is included in upstream. Shouldn't the
default config try to work with the default imx*.dts files included?

> > This used to work mostly fine with the generic phy driver but since
> > commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer
> I guess you should get a checkpatch error here.

Because I didn't reference that other commit right? Sorry about this.

Should I submit again with an improved commit message?

> > performs a soft reset on startup. This causes netboot to sometimes
> > timeout on DHCP because RX doesn't work right. DHCP is eventually retried
> > and
> Probably another checkpatch warning.

Why, line too long?

> > This was generated with "make savedefconfig" and it includes a few
> > additional minor cleanups.
> > 
> It is a bit strange, after apply your patch, i still get a lot difference
> as follows when savedefconfig:
> 
> I don't know what's wrong. Toolchains difference?

Maybe, kconfig acts strangely sometimes. It's not clear option ordering is
guaranteed to be stable. I don't think it matters though.

--
Regards,
Leonard