linux-kernel - Re: [PATCH] ATM: dts: at91: sama5d2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170328113452.bje7har2ymbr32ad@piout.net>
Date:   Tue, 28 Mar 2017 13:34:52 +0200
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     m18063 <Claudiu.Beznea@...rochip.com>
Cc:     "nicolas.ferre@...el.com" <nicolas.ferre@...el.com>,
        "boris.brezillon@...e-electrons.com" 
        <boris.brezillon@...e-electrons.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "pawel.moll@....com" <pawel.moll@....com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
        "galak@...eaurora.org" <galak@...eaurora.org>,
        "ludovic.desroches@...el.com" <ludovic.desroches@...el.com>,
        "cyrille.pitchen@...el.com" <cyrille.pitchen@...el.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller

Hi,

On 28/03/2017 at 14:04:25 +0300, m18063 wrote:
> >> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> >> index cd459e8..e88785e 100644
> >> --- a/arch/arm/boot/dts/sama5d2.dtsi
> >> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> >> @@ -1098,6 +1098,14 @@
> >>  				status = "disabled";
> >>  			};
> >>  
> >> +			pwm0: pwm@...2c000 {
> >> +				compatible = "atmel,sama5d2-pwm";
> > This compatible is not documented and is not used in any driver. Is that
> > really working?
> 
> At the moment I send this patch another driver patch was send
> to used this device tree bindings and also to document it.
> Meanwhile you reviewed also that other patch.
> 

Yes, I received that patch first, without the other ones. You should
have put everything in the same series.

> Please let me know if you want to send again this DT patch since
> I didn't yet receive any inputs its v2.
> 

I'll take it once the pwm patch are taken by Thierry because it is not
useful as-is, unless you use:
 compatible = "atmel,sama5d2-pwm", "atmel,sama5d3-pwm";


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com