linux-kernel - Re: [PATCH v3 3/3] perf annotate: Fix missing number of samples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3a7d217-977b-115e-5313-8e0707182b60@gmail.com>
Date:   Tue, 28 Mar 2017 21:09:44 +0900
From:   Taeung Song <treeze.taeung@...il.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:     linux-kernel@...r.kernel.org, Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Wang Nan <wangnan0@...wei.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>,
        Martin Liška <mliska@...e.cz>
Subject: Re: [PATCH v3 3/3] perf annotate: Fix missing number of samples

Good morning, Arnaldo :)

On 03/28/2017 03:26 AM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Mar 27, 2017 at 04:10:38PM +0900, Taeung Song escreveu:
>> If running 'perf annotate --stdio -l --show-total-period',
>> you can see a problem showing only zero '0' for number of samples.
>>
>> Before:
>>     $ perf annotate --stdio -l --show-total-period
>> ...
>>        0 :        400816:       push   %rbp
>>        0 :        400817:       mov    %rsp,%rbp
>>        0 :        40081a:       mov    %edi,-0x24(%rbp)
>>        0 :        40081d:       mov    %rsi,-0x30(%rbp)
>>        0 :        400821:       mov    -0x24(%rbp),%eax
>>        0 :        400824:       mov    -0x30(%rbp),%rdx
>>        0 :        400828:       mov    (%rdx),%esi
>>        0 :        40082a:       mov    $0x0,%edx
>> ...
>>
>> The reason is number of samples aren't set
>> in symbol__get_source_line(). so set it ordinarily.
>
> Can you please take a look at:
>
>   0c4a5bcea460 ("perf annotate: Display total number of samples with --show-total-period")
>
> that introduced the --show-total-period code and take it into account in
> this fix?
>
> I.e. from a quick look it did the calculation setting that field in the
> TUI code, where it should have done in the util/annotate.c file, so that
> all UIs would be able to use it.
>
> After your analysis, please add a Fixes: that cset, ok?
>
> I applied the other two patches and added Martin to the CC list, as he
> is the author of that patch and may have something to say here.
>
> - Arnaldo
>

Okey! I look into the cset 0c4a5bcea460.

It is fine but if running 'show-total-period' with '-l',
the problem happen. The reason is to miss setting number of samples
for source_line_samples, so will send v4 added Fixes: and Cc: Martin
(and a bit changed commit log message)

Thanks,
Taeung