linux-kernel - Re: [PATCH v2] usb: phy: isp1301: Add OF device ID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d079130e-4072-9ad9-ab01-9811e427a030@osg.samsung.com>
Date:   Tue, 28 Mar 2017 09:54:23 -0400
From:   Javier Martinez Canillas <javier@....samsung.com>
To:     Felipe Balbi <balbi@...nel.org>, linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v2] usb: phy: isp1301: Add OF device ID table

Hello Felipe,

On 03/28/2017 09:45 AM, Felipe Balbi wrote:
> 
> Hi,
> 
> Javier Martinez Canillas <javier@....samsung.com> writes:
>> The driver doesn't have a struct of_device_id table but supported devices
>> are registered via Device Trees. This is working on the assumption that a
>> I2C device registered via OF will always match a legacy I2C device ID and
>> that the MODALIAS reported will always be of the form i2c:<device>.
>>
>> But this could change in the future so the correct approach is to have an
>> OF device ID table if the devices are registered via OF.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> 
> this is already upstream. Care to send an incremental diff in case we
> need this fixed further?
> 

Ah, sorry. I missed that was already picked. Sure, I'll post an incremental
diff on top of v1. Thanks!

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America