linux-kernel - Re: [PATCH] aspeed-lpc-ctrl: include linux/types.h for uapi header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACPK8XfgP+KqnpfkPjqMPQ6GHqJ1gNR9Q3vE6jZCD82htwY9cw@mail.gmail.com>
Date:   Wed, 29 Mar 2017 00:45:18 +1030
From:   Joel Stanley <joel@....id.au>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Cyril Bur <cyrilbur@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] aspeed-lpc-ctrl: include linux/types.h for uapi header

On Wed, Mar 29, 2017 at 12:40 AM, Arnd Bergmann <arnd@...db.de> wrote:
> The newly added header file triggers a sanity check:
>
> usr/include/linux/aspeed-lpc-ctrl.h:44: found __[us]{8,16,32,64} type without #include <linux/types.h>

Thanks Arnd.

What tool are you running to do this check?

> We should include linux/types.h explicitly to ensure the header
> can be included from user space.
>
> Fixes: 6c4e97678501 ("drivers/misc: Add Aspeed LPC control driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Joel Stanley <joel@....id.au>

Cheers,

Joel

> ---
>  include/uapi/linux/aspeed-lpc-ctrl.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/aspeed-lpc-ctrl.h b/include/uapi/linux/aspeed-lpc-ctrl.h
> index f96fa995a3f0..c328c976c684 100644
> --- a/include/uapi/linux/aspeed-lpc-ctrl.h
> +++ b/include/uapi/linux/aspeed-lpc-ctrl.h
> @@ -11,6 +11,7 @@
>  #define _UAPI_LINUX_ASPEED_LPC_CTRL_H
>
>  #include <linux/ioctl.h>
> +#include <linux/types.h>
>
>  /* Window types */
>  #define ASPEED_LPC_CTRL_WINDOW_FLASH   1
> --
> 2.9.0
>