linux-kernel - Re: [PATCH] scsi: osd_uld: remove an unneeded NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq14lye6u8n.fsf@oracle.com>
Date:   Mon, 27 Mar 2017 21:54:48 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Boaz Harrosh <ooo@...ctrozaur.com>,
        Benny Halevy <bhalevy@...marydata.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        osd-dev@...n-osd.org, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] scsi: osd_uld: remove an unneeded NULL check

Dan Carpenter <dan.carpenter@...cle.com> writes:

> We don't call the remove() function unless probe() succeeds so "oud"
> can't be NULL here.  Plus, if it were NULL, we dereference it on the
> next line so it would crash anyway.

Applied to 4.12/scsi-queue (by hand).

-- 
Martin K. Petersen	Oracle Linux Engineering