linux-kernel - Re: [PATCH] drm: mali-dp: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170328145523.GO6816@e110455-lin.cambridge.arm.com>
Date:   Tue, 28 Mar 2017 15:55:23 +0100
From:   Liviu Dudau <liviu.dudau@....com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Brian Starkey <brian.starkey@....com>,
        Mali DP Maintainers <malidp@...s.arm.com>,
        David Airlie <airlied@...ux.ie>,
        Ville Syrjälä <ville.syrjala@...ux.intel.com>,
        Mihail Atanassov <mihail.atanassov@....com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Shailendra Verma <shailendra.v@...sung.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: mali-dp: remove unused variable

On Tue, Mar 28, 2017 at 04:07:58PM +0200, Arnd Bergmann wrote:
> The newly introduced function causes a harmless build warning:
> 
> drivers/gpu/drm/arm/malidp_planes.c: In function 'malidp_plane_atomic_print_state':
> drivers/gpu/drm/arm/malidp_planes.c:98:23: error: unused variable 'mp' [-Werror=unused-variable]
> 
> The variable serves no purpose here and can be removed.

Ouch, shame on me for not noticing it :(

Thanks for this!

Acked-by: Liviu Dudau <Liviu.Dudau@....com>

> 
> Fixes: 242f43b69c61 ("drm: mali-dp: add atomic_print_state for planes")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/gpu/drm/arm/malidp_planes.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
> index 5b0bad87f0b5..afd59e0f7918 100644
> --- a/drivers/gpu/drm/arm/malidp_planes.c
> +++ b/drivers/gpu/drm/arm/malidp_planes.c
> @@ -95,7 +95,6 @@ static void malidp_plane_atomic_print_state(struct drm_printer *p,
>  					    const struct drm_plane_state *state)
>  {
>  	struct malidp_plane_state *ms = to_malidp_plane_state(state);
> -	struct malidp_plane *mp = to_malidp_plane(state->plane);
>  
>  	drm_printf(p, "\trotmem_size=%u\n", ms->rotmem_size);
>  	drm_printf(p, "\tformat_id=%u\n", ms->format);
> -- 
> 2.9.0
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯