linux-kernel - Re: [PATCH v2] trace: Make trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170328110835.7f003609@gandalf.local.home>
Date:   Tue, 28 Mar 2017 11:08:35 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Deepa Dinamani <deepa.kernel@...il.com>
Cc:     mingo@...hat.com, linux-kernel@...r.kernel.org, arnd@...db.de,
        y2038@...ts.linaro.org
Subject: Re: [PATCH v2] trace: Make trace_hwlat timestamp y2038 safe

On Tue, 28 Mar 2017 07:50:17 -0700
Deepa Dinamani <deepa.kernel@...il.com> wrote:

> diff --git a/kernel/trace/trace_hwlat.c b/kernel/trace/trace_hwlat.c
> index 21ea6ae..2257ff1 100644
> --- a/kernel/trace/trace_hwlat.c
> +++ b/kernel/trace/trace_hwlat.c
> @@ -83,7 +83,7 @@ struct hwlat_sample {
>  	u64		duration;	/* delta */
>  	u64		outer_duration;	/* delta (outer loop) */
>  	u64		nmi_total_ts;	/* Total time spent in NMIs */
> -	struct timespec	timestamp;	/* wall time */
> +	struct timespec64	timestamp;	/* wall time */
>  	int		nmi_count;	/* # NMIs during this sample */
>  };
>  

This is a nit, but please make all the fields line up nicely again.
That is, add a tab to each line.

Thanks,

-- Steve