linux-kernel - Re: memory hotplug and force

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2203902.lsAnRkUs2Y@aspire.rjw.lan>
Date:   Tue, 28 Mar 2017 17:22:58 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Michal Hocko <mhocko@...nel.org>
Cc:     Toshi Kani <toshi.kani@...com>, Jiri Kosina <jkosina@...e.cz>,
        joeyli <jlee@...e.com>, linux-mm@...ck.org,
        LKML <linux-kernel@...r.kernel.org>, linux-api@...r.kernel.org
Subject: Re: memory hotplug and force_remove

On Tuesday, March 28, 2017 09:58:08 AM Michal Hocko wrote:
> On Mon 20-03-17 22:24:42, Rafael J. Wysocki wrote:
> > On Monday, March 20, 2017 03:29:39 PM Michal Hocko wrote:
> > > Hi Rafael,
> > 
> > Hi,
> > 
> > > we have been chasing the following BUG() triggering during the memory
> > > hotremove (remove_memory):
> > > 	ret = walk_memory_range(PFN_DOWN(start), PFN_UP(start + size - 1), NULL,
> > > 				check_memblock_offlined_cb);
> > > 	if (ret)
> > > 		BUG();
> > > 
> > > and it took a while to learn that the issue is caused by
> > > /sys/firmware/acpi/hotplug/force_remove being enabled. I was really
> > > surprised to see such an option because at least for the memory hotplug
> > > it cannot work at all. Memory hotplug fails when the memory is still
> > > in use. Even if we do not BUG() here enforcing the hotplug operation
> > > will lead to problematic behavior later like crash or a silent memory
> > > corruption if the memory gets onlined back and reused by somebody else.
> > > 
> > > I am wondering what was the motivation for introducing this behavior and
> > > whether there is a way to disallow it for memory hotplug. Or maybe drop
> > > it completely. What would break in such a case?
> > 
> > Honestly, I don't remember from the top of my head and I haven't looked at
> > that code for several months.
> > 
> > I need some time to recall that.
> 
> Did you have any chance to look into this?

Well, yes.

It looks like that was added for some people who depended on the old behavior
at that time.

I guess we can try to drop it and see what happpens. :-)

Thanks,
Rafael