| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <BY2PR11MB0837EED36FBC3BAF061272FAE7320@BY2PR11MB0837.namprd11.prod.outlook.com>
Date: Tue, 28 Mar 2017 15:36:02 +0000
From: Ryans Lee <RyanS.Lee@...imintegrated.com>
To: Rob Herring <robh@...nel.org>
CC: "lgirdwood@...il.com" <lgirdwood@...il.com>,
"broonie@...nel.org" <broonie@...nel.org>,
"mark.rutland@....com" <mark.rutland@....com>,
"perex@...ex.cz" <perex@...ex.cz>,
"tiwai@...e.com" <tiwai@...e.com>,
"kuninori.morimoto.gx@...esas.com" <kuninori.morimoto.gx@...esas.com>,
"arnd@...db.de" <arnd@...db.de>,
"ckeepax@...nsource.wolfsonmicro.com"
<ckeepax@...nsource.wolfsonmicro.com>,
"lars@...afoo.de" <lars@...afoo.de>,
"bardliao@...ltek.com" <bardliao@...ltek.com>,
"nh6z@...z.net" <nh6z@...z.net>,
"KCHSU0@...oton.com" <KCHSU0@...oton.com>,
"axel.lin@...ics.com" <axel.lin@...ics.com>,
"romain.perier@...labora.com" <romain.perier@...labora.com>,
"petr@...ix.com" <petr@...ix.com>,
"srinivas.kandagatla@...aro.org" <srinivas.kandagatla@...aro.org>,
"oder_chiou@...ltek.com" <oder_chiou@...ltek.com>,
"Paul.Handrigan@...rus.com" <Paul.Handrigan@...rus.com>,
"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"dgreid@...gle.com" <dgreid@...gle.com>,
"ryan.lee.maxim@...il.com" <ryan.lee.maxim@...il.com>
Subject: RE: [PATCH] ASoC: Add support for Maxim Integrated MAX98927 Amplifier
> -----Original Message-----
> From: Rob Herring [mailto:robh@...nel.org]
> Sent: Friday, March 24, 2017 8:26 AM
> To: Ryans Lee <RyanS.Lee@...imintegrated.com>
> Cc: lgirdwood@...il.com; broonie@...nel.org; mark.rutland@....com;
> perex@...ex.cz; tiwai@...e.com; kuninori.morimoto.gx@...esas.com;
> arnd@...db.de; ckeepax@...nsource.wolfsonmicro.com; lars@...afoo.de;
> bardliao@...ltek.com; nh6z@...z.net; KCHSU0@...oton.com;
> axel.lin@...ics.com; romain.perier@...labora.com; petr@...ix.com;
> srinivas.kandagatla@...aro.org; oder_chiou@...ltek.com;
> Paul.Handrigan@...rus.com; alsa-devel@...a-project.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> dgreid@...gle.com
> Subject: Re: [PATCH] ASoC: Add support for Maxim Integrated MAX98927
> Amplifier
>
> EXTERNAL EMAIL
>
>
>
> On Mon, Mar 20, 2017 at 09:40:23AM +0900, Ryan Lee wrote:
>> Signed-off-by: Ryan Lee <ryans.lee@...imintegrated.com>
>> ---
>> Resubmit the intial version of MAX98927 driver. Added all fixes into the initial patch.
>>
>> .../devicetree/bindings/sound/max98927.txt | 39 +
>> sound/soc/codecs/Kconfig | 5 +
>> sound/soc/codecs/Makefile | 2 +
>> sound/soc/codecs/max98927.c | 1040 ++++++++++++++++++++
>> sound/soc/codecs/max98927.h | 267 +++++
>> 5 files changed, 1353 insertions(+)
>> create mode 100755
>> Documentation/devicetree/bindings/sound/max98927.txt
>> mode change 100644 => 100755 sound/soc/codecs/Kconfig mode change
>> 100644 => 100755 sound/soc/codecs/Makefile create mode 100755
>> sound/soc/codecs/max98927.c create mode 100755
>> sound/soc/codecs/max98927.h
>>
>> diff --git a/Documentation/devicetree/bindings/sound/max98927.txt
>> b/Documentation/devicetree/bindings/sound/max98927.txt
>> new file mode 100755
>> index 0000000..d610879
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/max98927.txt
>> @@ -0,0 +1,39 @@
>> +max98927 audio CODEC
>> +
>> +This device supports I2C.
>
> Can we combine this and the other max9892x bindings. They all look similar.
They are not same but almost similar. I combined MAX98925, MAX98926 and MAX98927 bindings into MAX9892x.txt
Thank you for your feedback.
>
>> +
>> +Required properties:
>> +
>> + - compatible : "maxim,max98927"
>> +
>> + - maxim,vmon-slot-no : slot number used to send voltage
>> + information
>
> While vendor prefix is preferred, so is using the same property names.
> Either use the existing names or deprecate the old ones in favor of these.
To use same property names, I kept existing names. Thanks.
>
>> + or in inteleave mode this will be used as
>> + interleave slot.
>> + This property can be set to values from 0 to 15 for slot 0 to 15.
>> + Default value is 0.
>> +
>> + - maxim,imon-slot-no : slot number used to send current information
>> + This property can be set to values from 0 to 15 for slot 0 to 15.
>> + Default value is 0.
>> +
>> + - maxim,interleave-mode : When using two MAX98927 in a system it is
>> + possible to create ADC data that that will
>> + overflow the frame size. Digital Audio Interleave
>> + mode provides a means to output VMON and IMON data
>> + from two devices on a single DOUT line when running
>> + smaller frames sizes such as 32 BCLKS per LRCLK or
>> + 48 BCLKS per LRCLK.
>> + This property can be set to values from 0 to 1 for off and on.
>> + Default value is 0.
>> +
>> + - reg : the I2C address of the device for I2C
>> +
>> +Example:
>> +
>> +codec: max98927@3a {
>> + compatible = "maxim,max98927";
>> + maxim,vmon-slot-no = <0>;
>> + maxim,imon-slot-no = <1>;
>> + maxim,interleave-mode = <0>;
>> + reg = <0x3a>;
>> +};
Powered by blists - more mailing lists