lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 28 Mar 2017 21:49:58 -0700 (PDT) From: David Miller <davem@...emloft.net> To: colin.king@...onical.com Cc: jhansen@...are.com, aditr@...are.com, julia.lawall@...6.fr, stefanha@...hat.com, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] VSOCK: remove unnecessary ternary operator on return value From: Colin King <colin.king@...onical.com> Date: Tue, 28 Mar 2017 16:54:24 +0100 > From: Colin Ian King <colin.king@...onical.com> > > Rather than assign the positive errno values to ret and then > checking if it is positive and flip the sign, just set ret to > be the -ve errno value. > > Detected by CoverityScan, CID#986649 ("Logically Dead Code") > > Signed-off-by: Colin Ian King <colin.king@...onical.com> Just return the error directly instead of having this variable. Thanks.
Powered by blists - more mailing lists