linux-kernel - Re: [PATCH] input: matrix_keypad: add option to drive inactive columns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170329071502.GC38261@dtor-ws>
Date:   Wed, 29 Mar 2017 00:15:02 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     David Rivshin <drivshin@...rd.com>,
        Mark Rutland <mark.rutland@....com>,
        linux-input@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: matrix_keypad: add option to drive inactive
 columns

On Tue, Mar 28, 2017 at 09:02:29PM -0500, Rob Herring wrote:
> On Wed, Mar 22, 2017 at 04:16:50PM -0400, David Rivshin wrote:
> > From: David Rivshin <DRivshin@...worx.com>
> > 
> > The gpio-matrix-keypad driver normally sets inactive columns as inputs
> > while scanning. This does not work for all hardware, which may require
> > the inactive columns to be actively driven in order to overcome any
> > pull-ups/downs on the columns.
> > 
> > Signed-off-by: David Rivshin <drivshin@...worx.com>
> > ---
> >  .../devicetree/bindings/input/gpio-matrix-keypad.txt        |  2 ++
> >  drivers/input/keyboard/matrix_keypad.c                      | 13 +++++++++----
> >  include/linux/input/matrix_keypad.h                         |  3 +++
> >  3 files changed, 14 insertions(+), 4 deletions(-)
> 
> Acked-by: Rob Herring <robh@...nel.org>

Applied, thank you.

-- 
Dmitry