linux-kernel - Re: [PATCH v3] staging: goldfish: Fix style issues in macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170329071946.GB6503@kroah.com>
Date:   Wed, 29 Mar 2017 09:19:46 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     aviyae <aviyae42@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] staging: goldfish: Fix style issues in macros

On Mon, Mar 27, 2017 at 03:19:06PM +0300, aviyae wrote:
> Fix coding style issues in macros:
> 1. Add parenthesis around macro arguments
> 2. Avoid arguments reuse in macro

That's different things, please make different patches for this.

Remember, only one patch per "thing" and "fix all style issues" is not
"one thing" :)

thanks,

greg k-h