lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Mar 2017 11:33:54 +0200 (CEST) From: Jan Engelhardt <jengelh@...i.de> To: SIMRAN SINGHAL <singhalsimran0@...il.com> cc: wensong@...ux-vs.org, Simon Horman <horms@...ge.net.au>, Julian Anastasov <ja@....bg>, Pablo Neira Ayuso <pablo@...filter.org>, Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, lvs-devel@...r.kernel.org, netfilter-devel@...r.kernel.org, coreteam@...filter.org, linux-kernel@...r.kernel.org, outreachy-kernel <outreachy-kernel@...glegroups.com> Subject: Re: [PATCH v2] netfilter: Clean up tests if NULL returned on failure On Wednesday 2017-03-29 11:15, SIMRAN SINGHAL wrote: >>>>>> dest = kzalloc(sizeof(struct ip_vs_dest), GFP_KERNEL); >>>>>>- if (dest == NULL) >>>>>>+ if (!dest) >>>>>> return -ENOMEM; > >But, according to me we should prefer !var over ( var ==NULL ) according to the >coding style Where does it say that?
Powered by blists - more mailing lists