lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Mar 2017 11:56:08 +0200 From: Sylwester Nawrocki <s.nawrocki@...sung.com> To: Nicholas Mc Guire <hofrat@...dl.org> Cc: Kyungmin Park <kyungmin.park@...sung.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH RFC] [media] m5mols: add missing dependency on VIDEO_IR_I2C On 12/13/2016 06:44 AM, Nicholas Mc Guire wrote: > The Depends on: tag in Kconfig for CONFIG_VIDEO_M5MOLS does not list > VIDEO_IR_I2C so Kconfig displays the dependencies needed so the M-5MOLS > driver can not be found. > > Fixes: commit cb7a01ac324b ("[media] move i2c files into drivers/media/i2c") > Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org> > --- > > searching for VIDEO_M5MOLS in menuconfig currently shows the following > dependencies > Depends on: MEDIA_SUPPORT [=m] && I2C [=y] && VIDEO_V4L2 [=m] && \ > VIDEO_V4L2_SUBDEV_API [=y] && MEDIA_CAMERA_SUPPORT [=y] > but as the default settings include MEDIA_SUBDRV_AUTOSELECT=y the > "I2C module for IR" submenu (CONFIG_VIDEO_IR_I2C) is not displayed > adding the VIDEO_IR_I2C to the dependency list makes this clear > drivers/media/i2c/m5mols/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/m5mols/Kconfig b/drivers/media/i2c/m5mols/Kconfig > index dc8c250..6847a1b 100644 > --- a/drivers/media/i2c/m5mols/Kconfig > +++ b/drivers/media/i2c/m5mols/Kconfig > @@ -1,6 +1,6 @@ > config VIDEO_M5MOLS > tristate "Fujitsu M-5MOLS 8MP sensor support" > - depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API > + depends on I2C && VIDEO_IR_I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API There should be no need to enable the "I2C module for IR" to use m5mols driver, so the bug fix needs to be somewhere else. -- Thanks, Sylwester
Powered by blists - more mailing lists