linux-kernel - Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170329114752.bpfzkkvbvan3ayn5@sirena.org.uk>
Date:   Wed, 29 Mar 2017 12:47:52 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Daniel Baluta <daniel.baluta@...il.com>
Cc:     Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>,
        Daniel Baluta <daniel.baluta@....com>,
        Nicolin Chen <nicoleotsuka@...il.com>,
        alsa-devel@...a-project.org, Timur Tabi <timur@...i.org>,
        Xiubo.Lee@...il.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Takashi Iwai <tiwai@...e.com>, fabio.estevam@....com,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk
 cleanup

On Wed, Mar 29, 2017 at 02:38:23PM +0300, Daniel Baluta wrote:

> If I read the code correctly, both machine and codec driver are doing:

> * codec_clk = clk_get(...)

> I guess that the codec driver is the first to be loaded and it will call:

> * __clk_create_clk

> which will do the allocation. Then when machine driver is loaded, it
> will only take a reference to the allocated clock.

> I might be very wrong on this. Can you clarify what does moving allocation
> of the clock into codec driver implies? Machine driver only needs a reference
> to codec_clk to just get the clock's rate.

Oh, so the CODEC is already requesting the clock.  Then what I'm saying
is work out a way to use the handle to the clock that the CODEC driver
created.  In effect the machine driver is telling the CODEC driver to do
things with the input clock.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)