lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Mar 2017 15:04:48 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: Geert Uytterhoeven <geert@...ux-m68k.org> Cc: jacopo <jacopo@...ndi.org>, Jacopo Mondi <jacopo+renesas@...ndi.org>, Geert Uytterhoeven <geert+renesas@...der.be>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, Chris Brandt <chris.brandt@...esas.com>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Russell King <linux@...linux.org.uk>, Linux-Renesas <linux-renesas-soc@...r.kernel.org>, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc On Wed, Mar 29, 2017 at 1:20 PM, Geert Uytterhoeven <geert@...ux-m68k.org> wrote: >> I do not understand the notion of "flags" here. I hope that is not referring > > Flags refers to BI_DIR, SWIO_IN, and SWIO_OUT, from > https://patchwork.kernel.org/patch/9643047/ Aha I will go in and review that closer because it doesn't seem right. Sorry for missing it. >> i2c1_pins_a: i2c1@0 { >> pins { >> pinmux = <MT8135_PIN_195_SDA1__FUNC_SDA1>, >> <MT8135_PIN_196_SCL1__FUNC_SCL1>; > > If we follow this example, then we can list all combinations in > include/dt-bindings/pinctrl/r7s72100-pinctrl.h, instead of creating the value > by combining the bits using a macro where we need it in the DTS. > > It's gonna be a long list, though... Size is not the issue, readability is the issue. I don't see why you would need to list "all combinations" since the trees go through the C preprocessor so you can use macros and bit | OR to build them? Yours, Linus Walleij
Powered by blists - more mailing lists