lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Mar 2017 16:03:00 +0300 From: Adrian Hunter <adrian.hunter@...el.com> To: Piotr Sroka <piotrs@...ence.com>, linux-mmc@...r.kernel.org Cc: Ulf Hansson <ulf.hansson@...aro.org>, linux-kernel@...r.kernel.org, Masahiro Yamada <yamada.masahiro@...ionext.com> Subject: Re: [v5 1/4] mmc: sdhci-cadence: Fix writing PHY delay On 21/03/17 16:32, Piotr Sroka wrote: > Add polling for ACK to be sure that data are written to PHY register. > > Signed-off-by: Piotr Sroka <piotrs@...ence.com> Acked-by: Adrian Hunter <adrian.hunter@...el.com> > --- > Changes for v2: > - fix indent > --- > Changes for v3: > - none > --- > Changes for v4: > - none > --- > Changes for v5: > - use driver version from next branch, with applied enhanced strobe feature support. > --- > drivers/mmc/host/sdhci-cadence.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c > index 48f6419..83c3b55 100644 > --- a/drivers/mmc/host/sdhci-cadence.c > +++ b/drivers/mmc/host/sdhci-cadence.c > @@ -68,11 +68,12 @@ struct sdhci_cdns_priv { > bool enhanced_strobe; > }; > > -static void sdhci_cdns_write_phy_reg(struct sdhci_cdns_priv *priv, > - u8 addr, u8 data) > +static int sdhci_cdns_write_phy_reg(struct sdhci_cdns_priv *priv, > + u8 addr, u8 data) > { > void __iomem *reg = priv->hrs_addr + SDHCI_CDNS_HRS04; > u32 tmp; > + int ret; > > tmp = (data << SDHCI_CDNS_HRS04_WDATA_SHIFT) | > (addr << SDHCI_CDNS_HRS04_ADDR_SHIFT); > @@ -81,8 +82,14 @@ static void sdhci_cdns_write_phy_reg(struct sdhci_cdns_priv *priv, > tmp |= SDHCI_CDNS_HRS04_WR; > writel(tmp, reg); > > + ret = readl_poll_timeout(reg, tmp, tmp & SDHCI_CDNS_HRS04_ACK, 0, 10); > + if (ret) > + return ret; > + > tmp &= ~SDHCI_CDNS_HRS04_WR; > writel(tmp, reg); > + > + return 0; > } > > static void sdhci_cdns_phy_init(struct sdhci_cdns_priv *priv) >
Powered by blists - more mailing lists