lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Mar 2017 15:13:36 +0200 From: Niklas Cassel <niklas.cassel@...s.com> To: Kishon Vijay Abraham I <kishon@...com>, Bjorn Helgaas <bhelgaas@...gle.com>, Joao Pinto <Joao.Pinto@...opsys.com>, <linux-pci@...r.kernel.org>, <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>, <linux-omap@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org> CC: <hch@...radead.org>, <nsekhar@...com> Subject: Re: [GIT PULL] PCI: Support for configurable PCI endpoint On 03/29/2017 02:36 PM, Kishon Vijay Abraham I wrote: (snip) >>> >>> FWIW: >>> I've tested Kishon's tag pci-endpoint-for-4.12 >>> and PCIe on artpec6 SoC is still working fine. >> >> Thanks for testing it. >>> >>> I also included the DRA7xx PCIe driver in my >>> kernel so that pcie-designware-ep.c gets built. >>> >>> My only worry is that the code in pcie-designware-ep.c >>> is not compile tested if DRA7xx is not selected >>> (as it is the only driver using PCIE_DW_EP at >>> the moment). >> >> yeah, we should plan to include COMPILE_TEST in all pci drivers but I guess >> there is some problem with non-ARM builds [1]. As Bjorn mentioned in the >> thread, we could add #ifdef ARM and then include COMPILE_TEST. > > I think I misunderstood your concern. yeah, there is no direct way to compile > pcie-designware-ep.c without selecting DRA7xx. There is no way to compile pcie-designware-host.c + pcie-designware.c without selecting a driver that selects PCIE_DW_HOST, so I guess the same "problem" applies there. As long as kbuild builds PCI_DRA7XX_EP (and any driver that selects PCIE_DW_HOST), we should be fine.
Powered by blists - more mailing lists