lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 28 Mar 2017 21:00:58 -0500 From: Rob Herring <robh@...nel.org> To: Masahiro Yamada <yamada.masahiro@...ionext.com> Cc: linux-mtd@...ts.infradead.org, laurent.monat@...uantique.com, thorsten.christiansson@...uantique.com, Enrico Jorns <ejo@...gutronix.de>, Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>, Dinh Nguyen <dinguyen@...nel.org>, Boris Brezillon <boris.brezillon@...e-electrons.com>, Marek Vasut <marek.vasut@...il.com>, Graham Moore <grmoore@...nsource.altera.com>, David Woodhouse <dwmw2@...radead.org>, Masami Hiramatsu <mhiramat@...nel.org>, Chuanxiao Dong <chuanxiao.dong@...el.com>, Jassi Brar <jaswinder.singh@...aro.org>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Brian Norris <computersforpeace@...il.com>, Richard Weinberger <richard@....at>, Cyrille Pitchen <cyrille.pitchen@...el.com>, Mark Rutland <mark.rutland@....com> Subject: Re: [RESEND PATCH v2 13/53] mtd: nand: denali_dt: enable HW_ECC_FIXUP for Altera SOCFPGA variant On Thu, Mar 23, 2017 at 05:07:12AM +0900, Masahiro Yamada wrote: > There are various customizable parameters, so several variants for > this IP. A generic compatible like "denali,denali-nand-dt" is > useless. Moreover, there are multiple things wrong with this string. > (Refer to Rob's comment [1]) > > The denali_dt.c was split out and this compatible was added by Altera > for the SOCFPGA port. So, replace it with a more specific string. > > The Denali IP on SOCFPGA incorporates the hardware ECC fixup feature. > So, this capability should be associated with the compatible string. > > [1] https://lkml.org/lkml/2016/12/1/450 > > Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com> > --- > > Changes in v2: > - Add caps flag to of_device_id data, not hard-code in driver code > - Add Altera-specific compatible. > > Documentation/devicetree/bindings/mtd/denali-nand.txt | 5 +++-- > drivers/mtd/nand/denali_dt.c | 14 ++++++++++---- > 2 files changed, 13 insertions(+), 6 deletions(-) You should also mention there are no users (in-tree) of the old string. Acked-by: Rob Herring <robh@...nel.org>
Powered by blists - more mailing lists