lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Mar 2017 16:16:35 +0200 (CEST) From: Julia Lawall <julia.lawall@...6.fr> To: Arushi Singhal <arushisinghal19971997@...il.com> cc: outreachy-kernel@...glegroups.com, Wensong Zhang <wensong@...ux-vs.org>, Simon Horman <horms@...ge.net.au>, Julian Anastasov <ja@....bg>, Pablo Neira Ayuso <pablo@...filter.org>, Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, lvs-devel@...r.kernel.org, netfilter-devel@...r.kernel.org, coreteam@...filter.org, linux-kernel@...r.kernel.org Subject: Re: [Outreachy kernel] [PATCH] net: netfilter: remove unused variable On Wed, 29 Mar 2017, Arushi Singhal wrote: > This patch uses the following coccinelle script to remove > a variable that was simply used to store the return > value of a function call before returning it: > > @@ > identifier len,f; > @@ > > -int len; > ... when != len > when strict > -len = > +return > f(...); > -return len; > > Signed-off-by: Arushi Singhal <arushisinghal19971997@...il.com> > --- > net/netfilter/ipvs/ip_vs_ftp.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c > index d30c327bb578..9e1e682610ef 100644 > --- a/net/netfilter/ipvs/ip_vs_ftp.c > +++ b/net/netfilter/ipvs/ip_vs_ftp.c > @@ -482,11 +482,9 @@ static struct pernet_operations ip_vs_ftp_ops = { > > static int __init ip_vs_ftp_init(void) > { > - int rv; > > - rv = register_pernet_subsys(&ip_vs_ftp_ops); > /* rcu_barrier() is called by netns on error */ > - return rv; > + return register_pernet_subsys(&ip_vs_ftp_ops); It looks like you end up with an unnecessary blank line at the beginning of the function. julia > } > > /* > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com. > To post to this group, send email to outreachy-kernel@...glegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170329133848.GA1336%40arushi-HP-Pavilion-Notebook. > For more options, visit https://groups.google.com/d/optout. >
Powered by blists - more mailing lists