linux-kernel - Re: [PATCH 2/2] extcon: max77843: support USB accessories as external USB hosts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170329145035.fmnn3wxekw5lbh3q@jack.zhora.eu>
Date:   Wed, 29 Mar 2017 23:50:35 +0900
From:   Andi Shyti <andi@...zian.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Andi Shyti <andi.shyti@...sung.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Jaewon Kim <jaewon02.kim@...sung.com>,
        Seung-Woo Kim <sw0312.kim@...sung.com>,
        linux-kernel@...r.kernel.org, Andi Shyti <andi@...zian.org>
Subject: Re: [PATCH 2/2] extcon: max77843: support USB accessories as
 external USB hosts

Hi Krzysztof,

> > +                       case MAX77843_MUIC_ADC_RESERVED_ACC_1:
> > +                       case MAX77843_MUIC_ADC_RESERVED_ACC_2:
> > +                       case MAX77843_MUIC_ADC_RESERVED_ACC_3:
> > +                       case MAX77843_MUIC_ADC_RESERVED_ACC_4:
> > +                       case MAX77843_MUIC_ADC_RESERVED_ACC_5:
> 
> In commit msg you mentioned it but in code not. It looks weird to
> handle a vague "reserved" type in a specific way. How about adding
> some meaningful names instead of "reserved"? Or at least documenting,
> that they match Gear VR. Really, imagine later one would be looking at
> the code and trying to figure out why "reserved" means something

I know it's misleading, but that's the name from the datasheet,
that's why I tried to be more specific in the commit log.

In any case RESERVED_ACC stands for "reserved for external
accessory".

The Gear VR corresponds to MAX77843_MUIC_ADC_RESERVED_ACC_4, but
I don't think it's the only one, that's why it wouldn't be right
to call it e.g. MAX77843_MUIC_ADC_GEAR_VR.

I can of course add a comment on top of the above lines to make
it clearer.

Thanks,
Andi