lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Mar 2017 04:09:38 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: Nandor Han <nandor.han@...com> Cc: Alexandre Courbot <gnurou@...il.com>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 2/3] doc,dts - add XRA1403 DTS binding documentation On Mon, Mar 27, 2017 at 8:23 AM, Nandor Han <nandor.han@...com> wrote: > Add the XRA1403 DTS binding documentation. > > Signed-off-by: Nandor Han <nandor.han@...com> There is no big problem with this but: > +The XRA1403 is an 16-bit GPIO expander with an SPI interface. Features available: > + - Individually programmable inputs: > + - Internal pull-up resistors > + - Polarity inversion > + - Individual interrupt enable > + - Rising edge and/or Falling edge interrupt > + - Input filter Since you mention that it has interrupts maybe you want to add bindings for the cascaded interrupt and the interrupt-controller; keyword etc already now. We just document what the hardware can do, we don't have to do all of it in the first Linux driver submission. Yours, Linus Walleij
Powered by blists - more mailing lists