linux-kernel - Re: mm: BUG in resv_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e87e893-526b-7324-33fb-783a544bab11@oracle.com>
Date:   Tue, 28 Mar 2017 17:07:34 -0700
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     Andrew Morton <akpm@...ux-foundation.org>,
        Dmitry Vyukov <dvyukov@...gle.com>
Cc:     nyc@...omorphy.com, Michal Hocko <mhocko@...e.com>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Hillf Danton <hillf.zj@...baba-inc.com>
Subject: Re: mm: BUG in resv_map_release

On 03/28/2017 04:38 PM, Andrew Morton wrote:
> On Thu, 23 Mar 2017 11:19:38 +0100 Dmitry Vyukov <dvyukov@...gle.com> wrote:
> 
>> Hello,
>>
>> I've got the following BUG while running syzkaller fuzzer.
>> Note the injected kmalloc failure, most likely it's the root cause.
>>
> 
> Yes, probably the logic(?) in region_chg() leaked a
> resv->adds_in_progress++, although I'm not sure how.  And afaict that
> code can leak the memory at *nrg if the `trg' allocation attempt failed
> on the second or later pass around the retry loop.
> 
> Blah.  Does someone want to take a look at it?

I sent out a patch to address this and Hillf Acked.  Unfortunately,
there was a typo in your e-mail when I sent out the patch.  So, you
may not have noticed.

[PATCH] mm/hugetlb: Don't call region_abort if region_chg fails
http://marc.info/?l=linux-mm&m=149033588500724&w=2

If you need/want me to send again, let me know.
-- 
Mike Kravetz