lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Mar 2017 17:12:48 +0200 From: Jesper Nilsson <jesper.nilsson@...s.com> To: Richard Weinberger <richard@....at>, Artem Bityutskiy <dedekind1@...il.com>, Adrian Hunter <adrian.hunter@...el.com>, linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: [PATCH] ubifs: Don't block RENAME_WHITEOUT flag in rename The test does not allow the valid flag RENAME_WHITEOUT and in fact, the calling function of do_rename already tests the flags, so the test is unnecessary, allowing us to drop it completely. With this patch RENAME_WHITEOUT for overlayfs on ubifs works as intended. Signed-off-by: Jesper Nilsson <jesper.nilsson@...s.com> --- fs/ubifs/dir.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c index 30825d88..01ab543 100644 --- a/fs/ubifs/dir.c +++ b/fs/ubifs/dir.c @@ -1316,9 +1316,6 @@ static int do_rename(struct inode *old_dir, struct dentry *old_dentry, unsigned int uninitialized_var(saved_nlink); struct fscrypt_name old_nm, new_nm; - if (flags & ~RENAME_NOREPLACE) - return -EINVAL; - /* * Budget request settings: deletion direntry, new direntry, removing * the old inode, and changing old and new parent directory inodes. -- 2.1.4 /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@...s.com
Powered by blists - more mailing lists