lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Mar 2017 11:45:05 -0400 From: Paul Moore <paul@...l-moore.com> To: SF Markus Elfring <elfring@...rs.sourceforge.net> Cc: linux-security-module@...r.kernel.org, selinux@...ho.nsa.gov, Eric Paris <eparis@...isplace.org>, James Morris <james.l.morris@...cle.com>, "Serge E. Hallyn" <serge@...lyn.com>, Stephen Smalley <sds@...ho.nsa.gov>, William Roberts <william.c.roberts@...el.com>, LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org Subject: Re: [PATCH 43/46] selinux: Use kmalloc_array() in sidtab_init() On Sun, Jan 15, 2017 at 10:43 AM, SF Markus Elfring <elfring@...rs.sourceforge.net> wrote: > From: Markus Elfring <elfring@...rs.sourceforge.net> > Date: Sun, 15 Jan 2017 13:13:19 +0100 > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> > --- > security/selinux/ss/sidtab.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Merged, thanks. > diff --git a/security/selinux/ss/sidtab.c b/security/selinux/ss/sidtab.c > index 5840a35155fc..c9533b21942b 100644 > --- a/security/selinux/ss/sidtab.c > +++ b/security/selinux/ss/sidtab.c > @@ -18,7 +18,7 @@ int sidtab_init(struct sidtab *s) > { > int i; > > - s->htable = kmalloc(sizeof(*(s->htable)) * SIDTAB_SIZE, GFP_ATOMIC); > + s->htable = kmalloc_array(SIDTAB_SIZE, sizeof(*s->htable), GFP_ATOMIC); > if (!s->htable) > return -ENOMEM; > for (i = 0; i < SIDTAB_SIZE; i++) > -- > 2.11.0 > -- paul moore www.paul-moore.com
Powered by blists - more mailing lists