linux-kernel - Re: [PATCH] arch:x86/boot/compressed/error: Add declaration for necessary head file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJfVuRN_1uTPhy8w8Q0m=kbnCzvNqKWAJqsUyMxiByu1Q@mail.gmail.com>
Date:   Wed, 29 Mar 2017 09:48:22 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Zhengyi Shen <shenzhengyi@...il.com>,
        Ingo Molnar <mingo@...hat.com>
Cc:     "H. Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "x86@...nel.org" <x86@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arch:x86/boot/compressed/error: Add declaration for
 necessary head file

On Wed, Mar 29, 2017 at 12:00 AM, Zhengyi Shen <shenzhengyi@...il.com> wrote:
> Add declaration for the error.h file to correct the sparse warnings.
>
> Sparse warnings:
> arch/x86/boot/compressed/error.c:8:6:
>         warning: symbol 'warn' was not declared. Should it be static?
> arch/x86/boot/compressed/error.c:15:6:
>         warning: symbol 'error' was not declared. Should it be static?
>
> Signed-off-by: Zhengyi Shen <shenzhengyi@...il.com>

Thanks!

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

> ---
>  arch/x86/boot/compressed/error.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/boot/compressed/error.c b/arch/x86/boot/compressed/error.c
> index 6248740..3192202 100644
> --- a/arch/x86/boot/compressed/error.c
> +++ b/arch/x86/boot/compressed/error.c
> @@ -4,6 +4,7 @@
>   * memcpy() and memmove() are defined for the compressed boot environment.
>   */
>  #include "misc.h"
> +#include "error.h"
>
>  void warn(char *m)
>  {
> --
> 2.7.4
>



-- 
Kees Cook
Pixel Security