lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Mar 2017 21:12:57 +0200 From: Jacek Anaszewski <jacek.anaszewski@...il.com> To: Sebastian Reichel <sre@...nel.org>, Richard Purdie <rpurdie@...ys.net>, Pavel Machek <pavel@....cz>, Lee Jones <lee.jones@...aro.org> Cc: Tony Lindgren <tony@...mide.com>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, linux-leds@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCHv3 2/2] leds: cpcap: new driver Hi Sebastian, On 03/24/2017 09:47 AM, Sebastian Reichel wrote: > Motorola CPCAP is a PMIC (power management integrated circuit) found > in multiple smartphones. This driver adds support for the chip's LED > controllers. This introduces support for all controllers used by the > Droid 4. According to Motorola's driver (no datasheets available) > there a couple of more LED controllers. I did not add support for > them, since I cannot verify that they work with my modifications. > > Acked-by: Pavel Machek <pavel@....cz> > Signed-off-by: Sebastian Reichel <sre@...nel.org> > --- > Changes since PATCHv1: > - binding: reference common led binding for label > - drop DEBUG define (leftover) > - s/led/LED/g in debug prints > - order includes alphabetically > - introduce mutex, since led API is not atomic > - register led class after initial register setup > - use GPLv2+ in header > - drop unsupported leds from driver > > Changes since PATCHv2: > - use standard defines instead CPCAP_LED_OFF and CPCAP_LED_ON > > Notes: > - The "motorola" vendor-prefix is added via rtc-next > --- > .../devicetree/bindings/leds/cpcap-leds.txt | 29 +++ > drivers/leds/Kconfig | 9 + > drivers/leds/Makefile | 1 + > drivers/leds/leds-cpcap.c | 239 +++++++++++++++++++++ > 4 files changed, 278 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/cpcap-leds.txt > create mode 100644 drivers/leds/leds-cpcap.c > > diff --git a/Documentation/devicetree/bindings/leds/cpcap-leds.txt b/Documentation/devicetree/bindings/leds/cpcap-leds.txt > new file mode 100644 > index 000000000000..ebf7cdc7f70c > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/cpcap-leds.txt I've changed cpcap-leds.txt to leds-cpcap.txt to match the prevailing pattern for LED DT bindings file names. Please let me know if you have any objections. -- Best regards, Jacek Anaszewski
Powered by blists - more mailing lists