lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Mar 2017 22:18:20 +0100 From: Jonathan Cameron <jic23@...nel.org> To: Andrea della Porta <sfaragnaus@...il.com>, Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, Hartmut Knaack <knaack.h@....de>, Peter Meerwald-Stadler <pmeerw@...erw.net>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-iio@...r.kernel.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] coding style issue resolved On 28/03/17 13:01, Andrea della Porta wrote: > Coding style issue resolved. > > Signed-off-by: Andrea della Porta <sfaragnaus@...il.com> Please include the driver name in the title. Subsystem also good. staging:iio:accel:adis16029 drop braces around single element if block or something along those lines would be good. > --- > drivers/staging/iio/accel/adis16209.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/accel/adis16209.c b/drivers/staging/iio/accel/adis16209.c > index 52fa2e0..159a687 100644 > --- a/drivers/staging/iio/accel/adis16209.c > +++ b/drivers/staging/iio/accel/adis16209.c > @@ -255,9 +255,9 @@ static int adis16209_read_raw(struct iio_dev *indio_dev, > } > addr = adis16209_addresses[chan->scan_index][0]; > ret = adis_read_reg_16(st, addr, &val16); > - if (ret) { > + if (ret) > return ret; > - } > + > val16 &= (1 << bits) - 1; > val16 = (s16)(val16 << (16 - bits)) >> (16 - bits); > *val = val16; >
Powered by blists - more mailing lists