lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Mar 2017 02:58:28 +0530 From: SIMRAN SINGHAL <singhalsimran0@...il.com> To: Jonathan Cameron <jic23@...nel.org> Cc: Hartmut Knaack <knaack.h@....de>, Lars-Peter Clausen <lars@...afoo.de>, Peter Meerwald-Stadler <pmeerw@...erw.net>, linux-iio@...r.kernel.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, outreachy-kernel <outreachy-kernel@...glegroups.com> Subject: Re: [PATCH] iio: adc: max1363: constify attribute_group structures On Thu, Mar 30, 2017 at 2:41 AM, Jonathan Cameron <jic23@...nel.org> wrote: > On 28/03/17 21:15, simran singhal wrote: >> Check for attribute_group structures that are only stored in the >> event_attrs filed of iio_info structure. As the event_attrs field of >> iio_info structures is constant, so these attribute_group structures can >> also be declared constant. Done using coccinelle: >> >> @r1 disable optional_qualifier @ >> identifier i; >> position p; >> @@ >> static struct attribute_group i@p = {...}; >> >> @ok1@ >> identifier r1.i; >> position p; >> struct iio_info x; >> @@ >> x.event_attrs=&i@p; >> >> @bad@ >> position p!={r1.p,ok1.p}; >> identifier r1.i; >> @@ >> i@p >> >> @depends on !bad disable optional_qualifier@ >> identifier r1.i; >> @@ >> static >> +const >> struct attribute_group i={...}; >> >> @depends on !bad disable optional_qualifier@ >> identifier r1.i; >> @@ >> +const >> struct attribute_group i; >> >> File size before: >> text data bss dec hex filename >> 36951 448 0 37399 9217 drivers/iio/adc/max1363.o >> >> File size after: >> text data bss dec hex filename >> 37015 384 0 37399 9217 drivers/iio/adc/max1363.o >> >> Signed-off-by: simran singhal <singhalsimran0@...il.com> > Applied to the togreg branch of iio.git and pushed out as testing for > the autobuilders to play with it. > But my tree is up-to-date and I also test it before sending. > Thanks, > > Jonathan >> --- >> drivers/iio/adc/max1363.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c >> index c6c12fe..80eada4 100644 >> --- a/drivers/iio/adc/max1363.c >> +++ b/drivers/iio/adc/max1363.c >> @@ -1007,7 +1007,7 @@ static struct attribute *max1363_event_attributes[] = { >> NULL, >> }; >> >> -static struct attribute_group max1363_event_attribute_group = { >> +static const struct attribute_group max1363_event_attribute_group = { >> .attrs = max1363_event_attributes, >> }; >> >> >
Powered by blists - more mailing lists