lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Mar 2017 02:58:50 +0530 From: SIMRAN SINGHAL <singhalsimran0@...il.com> To: Jonathan Cameron <jic23@...nel.org> Cc: Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, Hartmut Knaack <knaack.h@....de>, Peter Meerwald-Stadler <pmeerw@...erw.net>, linux-iio@...r.kernel.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, outreachy-kernel <outreachy-kernel@...glegroups.com> Subject: Re: [PATCH] iio: adc: ad799x: constify attribute_group structures On Thu, Mar 30, 2017 at 2:43 AM, Jonathan Cameron <jic23@...nel.org> wrote: > On 28/03/17 21:07, simran singhal wrote: >> Check for attribute_group structures that are only stored in the >> event_attrs filed of iio_info structure. As the event_attrs field of >> iio_info structures is constant, so these attribute_group structures can >> also be declared constant. >> Done using coccinelle: >> >> @r1 disable optional_qualifier @ >> identifier i; >> position p; >> @@ >> static struct attribute_group i@p = {...}; >> >> @ok1@ >> identifier r1.i; >> position p; >> struct iio_info x; >> @@ >> x.event_attrs=&i@p; >> >> @bad@ >> position p!={r1.p,ok1.p}; >> identifier r1.i; >> @@ >> i@p >> >> @depends on !bad disable optional_qualifier@ >> identifier r1.i; >> @@ >> static >> +const >> struct attribute_group i={...}; >> >> @depends on !bad disable optional_qualifier@ >> identifier r1.i; >> @@ >> +const >> struct attribute_group i; >> >> File size before: >> text data bss dec hex filename >> 26051 464 0 26515 6793 drivers/iio/adc/ad799x.o >> >> File size after: >> text data bss dec hex filename >> 26115 400 0 26515 6793 drivers/iio/adc/ad799x.o >> >> Signed-off-by: simran singhal <singhalsimran0@...il.com> > Applied to the togreg branch of iio.git and pushed out as testing > for the autobuilders to play with it. > But my tree is up-to-date and I also test it before sending. > Thanks, > > Jonathan >> --- >> drivers/iio/adc/ad799x.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/iio/adc/ad799x.c b/drivers/iio/adc/ad799x.c >> index 9704090..22426ae 100644 >> --- a/drivers/iio/adc/ad799x.c >> +++ b/drivers/iio/adc/ad799x.c >> @@ -520,7 +520,7 @@ static struct attribute *ad799x_event_attributes[] = { >> NULL, >> }; >> >> -static struct attribute_group ad799x_event_attrs_group = { >> +static const struct attribute_group ad799x_event_attrs_group = { >> .attrs = ad799x_event_attributes, >> }; >> >> >
Powered by blists - more mailing lists