linux-kernel - Re: drivers/gpu/drm/radeon/r100.c:3303]: (style) Redundant condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CADnq5_MBC2ZEC4kUWU4Q_wz1Nzz3mtyZE9wibh6ZpFRaX9jM8g@mail.gmail.com>
Date:   Wed, 29 Mar 2017 18:09:49 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     David Binderman <dcb314@...mail.com>
Cc:     "alexander.deucher@....com" <alexander.deucher@....com>,
        "christian.koenig@....com" <christian.koenig@....com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: drivers/gpu/drm/radeon/r100.c:3303]: (style) Redundant condition

On Mon, Mar 27, 2017 at 6:07 AM, David Binderman <dcb314@...mail.com> wrote:
>
> Hello there,
>
> linux-4.11-rc4/drivers/gpu/drm/radeon/r100.c:3303]: (style) Redundant condition: If 'EXPR == 11', the comparison 'EXPR <= 12' is always true.
>
> Source code is
>
>     } else if (rdev->family == CHIP_RV350 ||
>            rdev->family <= CHIP_RV380) {
>

Fixed in the attached patch.


> Also in the same file:
>
> [drivers/gpu/drm/radeon/r100.c:2550]: (style) Variable 'tmp' is assigned a value
>  that is never used.
> [drivers/gpu/drm/radeon/r100.c:2875]: (style) Variable 'tmp' is assigned a value
>  that is never used.

These are intended.  The registers are read back to to post the previous write.

Alex

View attachment "0001-drm-radeon-fix-typo-in-bandwidth-calculation.patch" of type "text/x-diff" (1043 bytes)