linux-kernel - Re: [PATCH] kernel/reboot: add devm_register_reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHQ1cqEUTo3J2zzbiwZ7COHJs6oLbs_Mh88JU8zk7jEjFzyHEg@mail.gmail.com>
Date:   Thu, 30 Mar 2017 15:55:43 -0700
From:   Andrey Smirnov <andrew.smirnov@...il.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Chris Healy <cphealy@...il.com>
Subject: Re: [PATCH] kernel/reboot: add devm_register_reboot_notifier

On Wed, Mar 29, 2017 at 4:17 PM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
> On Mon, 20 Mar 2017 10:17:53 -0700 Andrey Smirnov <andrew.smirnov@...il.com> wrote:
>
>> Add devm_* wrapper around register_reboot_notifier to simplify device
>> specific reboot notifier registration/unregistration.
>>
>> --- a/kernel/reboot.c
>> +++ b/kernel/reboot.c
>> @@ -104,6 +104,33 @@ int unregister_reboot_notifier(struct notifier_block *nb)
>>  }
>>  EXPORT_SYMBOL(unregister_reboot_notifier);
>>
>> +static void devm_unregister_reboot_notifier(struct device *dev, void *res)
>> +{
>> +     WARN_ON(unregister_reboot_notifier(*(struct notifier_block **)res));
>> +}
>> +
>> +int devm_register_reboot_notifier(struct device *dev, struct notifier_block *nb)
>> +{
>> +     struct notifier_block **rcnb;
>> +     int ret;
>> +
>> +     rcnb = devres_alloc(devm_unregister_reboot_notifier,
>> +                         sizeof(*rcnb), GFP_KERNEL);
>> +     if (!rcnb)
>> +             return -ENOMEM;
>> +
>> +     ret = register_reboot_notifier(nb);
>> +     if (!ret) {
>> +             *rcnb = nb;
>> +             devres_add(dev, rcnb);
>> +     } else {
>> +             devres_free(rcnb);
>> +     }
>> +
>> +     return ret;
>> +}
>> +EXPORT_SYMBOL(devm_register_reboot_notifier);
>
> Seems reasonable.  Can we please have some patches which actually use
> this?

I will be submitting a serdev/watchdog driver in next couple of weeks,
I can CC you on that thread.

Thanks,
Andrey Smirnov