[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170330050430.GA3179@localhost.localdomain>
Date: Wed, 29 Mar 2017 22:04:30 -0700
From: Darren Hart <dvhart@...radead.org>
To: Jonathan Woithe <jwoithe@...t42.net>
Cc: Andy Shevchenko <andy.shevchenko@...il.com>,
Micha?? K??pie?? <kernel@...pniu.pl>,
Andy Shevchenko <andy@...radead.org>,
Platform Driver <platform-driver-x86@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event
handling
On Thu, Mar 30, 2017 at 02:26:26PM +1030, Jonathan Woithe wrote:
> On Wed, Mar 29, 2017 at 08:36:50PM -0700, Darren Hart wrote:
> > On Wed, Mar 29, 2017 at 07:35:50PM +0300, Andy Shevchenko wrote:
> > > On Wed, Mar 29, 2017 at 10:19 AM, Micha?? K??pie?? <kernel@...pniu.pl> wrote:
> > >
> > > > Darren, Andy, in light of the above I will be awaiting your review of
> > > > this series. I will submit v2 afterwards, with all remarks from both
> > > > you and Jonathan taken into account.
> > >
> > > Darren marked this series under his name to review, so, I let him to
> > > speak for us.
> >
> > The series looks good to me. Nice work Micha??. They are logically divided and
> > address issues in a procedural way (so I stopped commenting until I read the
> > full series through as a couple of times you addressed a concern from a move in
> > a cleanup to follow).
> >
> > I've applied the noted change to 7/8 and will run this through my tests, but
> > don't anticipate any problems. Jonathan, if you don't have any additional
> > concerns, let me know if I can add your Reviewed-by.
>
> With the noted change to 7/8 applied I'm happy with the resulting series.
> As you noted, there is still some scope for making things more consistent,
> especially with regard to error handling. However, that is really a
> separate task which can be addressed in a later series. This present series
> doesn't impact on this issue in any significant way so it makes sense that
> be applied.
>
> Reviewed-by: Jonathan Woithe <jwoithe@...t42.net>
Merged, thanks!
--
Darren Hart
VMware Open Source Technology Center
Powered by blists - more mailing lists