linux-kernel - Re: [PATCH net-next] virtio_net: don't reset twice on XDP on/off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8949b5e9-602d-eef0-acdb-9f0f9a5a6f54@redhat.com>
Date:   Thu, 30 Mar 2017 13:39:49 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>, linux-kernel@...r.kernel.org
Cc:     virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        John Fastabend <john.fastabend@...il.com>
Subject: Re: [PATCH net-next] virtio_net: don't reset twice on XDP on/off



On 2017年03月30日 04:14, Michael S. Tsirkin wrote:
> We already do a reset once in remove_vq_common -
> there appears to be no point in doing another one
> when we add/remove XDP.
>
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> ---
>   drivers/net/virtio_net.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index de42e9a..ed8f548 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -1810,7 +1810,6 @@ static int virtnet_reset(struct virtnet_info *vi, int curr_qp, int xdp_qp)
>   	virtnet_freeze_down(dev);
>   	_remove_vq_common(vi);
>   
> -	dev->config->reset(dev);
>   	virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE);
>   	virtio_add_status(dev, VIRTIO_CONFIG_S_DRIVER);
>   

Acked-by: Jason Wang <jasowang@...hat.com>