linux-kernel - Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170330074536.GA4814@Red>
Date:   Thu, 30 Mar 2017 09:45:36 +0200
From:   Corentin Labbe <clabbe.montjoie@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     arnd@...db.de, peppe.cavallaro@...com, alexandre.torgue@...com,
        Joao.Pinto@...opsys.com, treding@...dia.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote:
> From: Arnd Bergmann <arnd@...db.de>
> Date: Tue, 28 Mar 2017 11:48:21 +0200
> 
> > A driver must not access the two fields directly but should instead use
> > the helper functions to set the values and keep a consistent internal
> > state:
> > 
> > ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_dvr_probe':
> > ethernet/stmicro/stmmac/stmmac_main.c:4083:8: error: 'struct net_device' has no member named 'real_num_rx_queues'; did you mean 'real_num_tx_queues'?
> > 
> > Fixes: a8f5102af2a7 ("net: stmmac: TX and RX queue priority configuration")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Applied.

This break my revert patch. (since it patch ("net: stmmac: enable multiple buffers").
Since dwmac-sunxi is still broken, what can I do ? send two revert patch ? or adapt the reverting patch.