linux-kernel - Re: [PATCH v2 1/2] mmc: sdhci-acpi: Set MMC_CAP_AGGRESSIVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7b084ccd-8862-3430-0842-de496535d7e2@intel.com>
Date:   Thu, 30 Mar 2017 10:41:19 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Azhar Shaikh <azhar.shaikh@...el.com>, ulf.hansson@...aro.org,
        linux-mmc@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] mmc: sdhci-acpi: Set MMC_CAP_AGGRESSIVE_PM for
 BYT-related Intel controllers

On 29/03/17 21:16, Azhar Shaikh wrote:
> Set MMC_CAP_AGGRESSIVE_PM for BYT-related Intel SD card
> controllers.
> 
> Signed-off-by: Azhar Shaikh <azhar.shaikh@...el.com>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
> Changes in v2:
>   - Rebased the patch on top of 'next' branch.
>   - No code change.
> 
>  drivers/mmc/host/sdhci-acpi.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index 665c5f3..c6a9a1b 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -263,10 +263,8 @@ static int sdhci_acpi_sd_probe_slot(struct platform_device *pdev,
>  
>  	/* Platform specific code during sd probe slot goes here */
>  
> -	if (hid && !strcmp(hid, "80865ACA")) {
> +	if (hid && !strcmp(hid, "80865ACA"))
>  		host->mmc_host_ops.get_cd = bxt_get_cd;
> -		host->mmc->caps |= MMC_CAP_AGGRESSIVE_PM;
> -	}
>  
>  	return 0;
>  }
> @@ -302,7 +300,7 @@ static int sdhci_acpi_sd_probe_slot(struct platform_device *pdev,
>  	.quirks  = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,
>  	.quirks2 = SDHCI_QUIRK2_CARD_ON_NEEDS_BUS_ON |
>  		   SDHCI_QUIRK2_STOP_WITH_TC,
> -	.caps    = MMC_CAP_WAIT_WHILE_BUSY,
> +	.caps    = MMC_CAP_WAIT_WHILE_BUSY | MMC_CAP_AGGRESSIVE_PM,
>  	.probe_slot	= sdhci_acpi_sd_probe_slot,
>  };
>  
>